> Currently, jdk.jdeps uses reflective preview APIs. Such uses are permitted by 
> exporting `jdk.internal.javac` to `jdk.jdeps`. This is not preferable as such 
> an export is intended for normal preview APIs. We really just need to 
> suppress the warnings from use of preview APIs in the `Java.gmk` for 
> `jdk.jdeps` without hacking java.base.
> 
> This was discovered during the diff cleanup for lworld versus the latest 
> merged JDK 27 build 10 in #2171.
> 
> Testing: Building the JDK

Chen Liang has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains three additional commits since 
the last revision:

 - Tweak approach as recommended by Alex Buckley
 - Merge branch 'lworld' of https://github.com/openjdk/valhalla into 
fix/lw-jdeps-reflective-preview
 - jdeps use of reflective preview features

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2193/files
  - new: https://git.openjdk.org/valhalla/pull/2193/files/815f318f..babeae20

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2193&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2193&range=00-01

  Stats: 24336 lines in 677 files changed: 11847 ins; 6580 del; 5909 mod
  Patch: https://git.openjdk.org/valhalla/pull/2193.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2193/head:pull/2193

PR: https://git.openjdk.org/valhalla/pull/2193

Reply via email to