On Wed, 4 Mar 2026 17:30:32 GMT, Chen Liang <[email protected]> wrote:
>> Currently, jdk.jdeps uses reflective preview APIs. Such uses are permitted >> by exporting `jdk.internal.javac` to `jdk.jdeps`. This is not preferable as >> this is a hidden opt-in. In principle, reflective or normal preview API use >> should both be opt-in, so we make jdk.jdeps opt-in to preview features usage. >> >> This was discovered during the diff cleanup for lworld versus the latest >> merged JDK 27 build 10 in #2171. >> >> Testing: Building the JDK > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Tweak approach as recommended by Alex Buckley > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > fix/lw-jdeps-reflective-preview > - jdeps use of reflective preview features Thanks for the review! The module-info.java comment updates have been incorporated into the mainline sync patch at https://github.com/openjdk/jdk/pull/29944. Please help refresh the review there too. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2193#issuecomment-3999592903
