On Thu, 5 Mar 2026 12:36:42 GMT, Coleen Phillimore <[email protected]> wrote:
>> Stefan Karlsson has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 24 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> 8378086_obj_array_klass_code_deduplication >> - Add temporary assert >> - Restore ObjArrayKlass private >> - Remove create_element_klass_array_name duplication >> - Remove ObjArrayKlass::oop_verify_on implementation >> - Remove ObjArrayKlass::oop_size >> - Remove ObjArrayKlass::copy_array >> - Fix incorrect reference to RefArrayKlass:: >> - Deduplicate array klass code >> - Fixes from Stefan's comments >> - ... and 14 more: >> https://git.openjdk.org/valhalla/compare/646c2f93...24bd1bb1 > > src/hotspot/share/oops/arrayKlass.cpp line 133: > >> 131: } >> 132: >> 133: Symbol* ArrayKlass::create_element_klass_array_name(Klass* >> element_klass, JavaThread* current) { > > Should this be in ObjArrayKlass instead and removed here? It's not needed by > typeArrayKlass right? I did approve but I think the one in ArrayKlass should be removed, and the one in ObjArrayKlass is in mainline already. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2117#discussion_r2889855368
