On Thu, 5 Mar 2026 12:33:48 GMT, Coleen Phillimore <[email protected]> wrote:
>> Stefan Karlsson has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 24 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> 8378086_obj_array_klass_code_deduplication >> - Add temporary assert >> - Restore ObjArrayKlass private >> - Remove create_element_klass_array_name duplication >> - Remove ObjArrayKlass::oop_verify_on implementation >> - Remove ObjArrayKlass::oop_size >> - Remove ObjArrayKlass::copy_array >> - Fix incorrect reference to RefArrayKlass:: >> - Deduplicate array klass code >> - Fixes from Stefan's comments >> - ... and 14 more: >> https://git.openjdk.org/valhalla/compare/646c2f93...24bd1bb1 > > src/hotspot/share/oops/arrayKlass.hpp line 69: > >> 67: // The constructor with the Symbol argument does the real array >> 68: // initialization, the other is a dummy >> 69: ArrayKlass(int n, Symbol* name, KlassKind kind, ArrayProperties props); > > I see why you did this now. The field dimension is in ArrayKlass not > ObjArrayKlass. You should make this minor change in mainline, then have it > merged in here. OK. Let me work on that in upstream. > src/hotspot/share/oops/flatArrayKlass.cpp line 215: > >> 213: >> 214: // Check destination >> 215: if (!d->is_flatArray() && !d->is_refArray()) { > > There's an equivalent !is_refined_objArray() that can be used. Thanks. I'll change that. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2117#discussion_r2890210159 PR Review Comment: https://git.openjdk.org/valhalla/pull/2117#discussion_r2890212106
