On Thu, 5 Mar 2026 17:34:49 GMT, Frederic Parain <[email protected]> wrote:
>> Small patch fixing a missing memory barrier in FlatArrayKlass::copy_array. >> The unit test covers more scenario where a flat value has to be buffered >> before to be written to another heap variable. So far, these tests haven't >> shown any other issue (they were run repeatedly 50 times using Mach5). >> >> However, the unit test is quite heavy, testing 5 different scenarios, and >> running each for 3 minutes, using all detected cores of the machine each >> time. This might qualify this unit test as a "resourcehog" test, it then >> should be moved to test/hotspot/jtreg/resourcehogs/ >> >> Fred > > Frederic Parain has updated the pull request incrementally with one > additional commit since the last revision: > > Add new line at the end Changes requested by lmesnik (no project role). test/hotspot/jtreg/runtime/valhalla/inlinetypes/ValueTearingTest.java line 27: > 25: * @test > 26: * @library /test/lib > 27: * @requires vm.flagless Why is it flagless? Don't we want to run it with different compiler optimizations? test/hotspot/jtreg/runtime/valhalla/inlinetypes/ValueTearingTest.java line 30: > 28: * @modules java.base/jdk.internal.vm.annotation > java.base/jdk.internal.value > 29: * @enablePreview > 30: * @compile ValueTearingTest.java No need to compile this class explicitly, jtreg should do it. ------------- PR Review: https://git.openjdk.org/valhalla/pull/2183#pullrequestreview-3904464431 PR Review Comment: https://git.openjdk.org/valhalla/pull/2183#discussion_r2896459513 PR Review Comment: https://git.openjdk.org/valhalla/pull/2183#discussion_r2896461748
