On Thu, 5 Mar 2026 17:34:49 GMT, Frederic Parain <[email protected]> wrote:
>> Small patch fixing a missing memory barrier in FlatArrayKlass::copy_array. >> The unit test covers more scenario where a flat value has to be buffered >> before to be written to another heap variable. So far, these tests haven't >> shown any other issue (they were run repeatedly 50 times using Mach5). >> >> However, the unit test is quite heavy, testing 5 different scenarios, and >> running each for 3 minutes, using all detected cores of the machine each >> time. This might qualify this unit test as a "resourcehog" test, it then >> should be moved to test/hotspot/jtreg/resourcehogs/ >> >> Fred > > Frederic Parain has updated the pull request incrementally with one > additional commit since the last revision: > > Add new line at the end Note that this requirement makes the `flatArrayOopDesc::obj_at` much more dangerous to use than the old objArrayOopDesc::obj_at. Every place where we use this function and then make a publishing store needs to remember to perform this barrier. I wonder if we shouldn't find another, more conspicuous name that makes the users / readers aware that this is can be dangerous to use. Alternatively, push the barrier into the `obj_at` function? ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2183#issuecomment-4009812853
