On Tue, 10 Mar 2026 06:53:17 GMT, Axel Boldt-Christmas <[email protected]> wrote:
>> src/hotspot/share/code/vtableStubs.cpp line 269: >> >>> 267: address vtable_index_addr = vtable_stub_addr + offset_of(VtableStub, >>> _index); >>> 268: bool is_vtable_stub = *vtable_type_addr == >>> static_cast<uint8_t>(VtableStub::Type::vtable_stub); >>> 269: bool caller_is_c1 = *vtable_caller_type_addr == >>> static_cast<uint8_t>(VtableStub::CallerType::c1); >> >> This makes me squint - can you add ()? > > Or? Not sure what precedence you want to clarify here. @coleenp > Suggestion: > > bool caller_is_c1 = (*vtable_caller_type_addr) == > static_cast<uint8_t>(VtableStub::CallerType::c1); I'd prefer he former, `bool caller_is_c1 = (... == ...)`. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2206#discussion_r2911957730
