On Mon, 16 Mar 2026 02:00:55 GMT, David Holmes <[email protected]> wrote:
> Can you clarify please exactly what the test code is doing in relation to all > these objects - it is not clear to me what simply ignoring the value objects > implies. AFAIU the tests verify SampledObjectAlloc, to get the events it allocates int arrays. But the API just generates events when a threshold is reached, reporting the last allocated object, so any object can be reported and sometimes we get value objects. My main concern was that skipping events with value objects can cause some failures due wrong calculations, but testing didn't show the failures. > > It's not yet decided how would be better to update SampledObjectAlloc > > Is there a JBS issue tracking this? Not yet. Going to file it after some discussions about better way to fix it. This fix is mostly to unblock work on throwing IdentityException from NewWeakGlobalRef ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2230#issuecomment-4070263965
