On Mon, 16 Mar 2026 01:59:35 GMT, David Holmes <[email protected]> wrote:
>> Alex Menkov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - restore empty line
>> - use IsValueObject
>
> test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp
> line 539:
>
>> 537: if (err == JVMTI_ERROR_NONE && count >= 1) {
>> 538: if (jni->IsValueObject(object)) {
>> 539: // weak references are prohibited for value objects, skip them
>
> Wouldn't it be better to do this upfront before getting the stack trace?
yes, GetStackTrace is not excepted to fail (nor frame count == 0)
Fixed
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2230#discussion_r2942801189
