On Fri, 27 Mar 2026 01:13:01 GMT, Roger Riggs <[email protected]> wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Split AddAll test into separate NoPreview and Preview scenarios using
>> @enablePreview tag.
>
> test/lib/jdk/test/lib/valueclass/ValueClass.java line 47:
>
>> 45: @Retention(RetentionPolicy.SOURCE)
>> 46: @Target(ElementType.TYPE)
>> 47: public @interface ValueClass {}
>
> The name `ValueClass` does not reflect the conditional or test context use of
> the annotation.
> It should be named to convey that it is a parameter to the test or condition.
>
> Maybe "TestableAsValueClass", or ...
Would it be better to name it AsValueClass?
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2253#discussion_r3002410968
