On Fri, 27 Mar 2026 00:39:22 GMT, Leonid Mesnik <[email protected]> wrote:
>> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Split AddAll test into separate NoPreview and Preview scenarios using >> @enablePreview tag. > > make/RunTests.gmk line 884: > >> 882: endif >> 883: >> 884: ifneq ($$(wildcard $$(JTREG_VALUE_CLASS_ANNOTATION_JAR)), ) > > Do we need to add this jar into cpa? > > The tests should add '/test/lib' library and should compile this > annotationati anyway? Yeah, you're right. This code is redundant after the restructuring. We don't need to add the ValueClass annotation to the cpa. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2253#discussion_r3002481954
