On Mon, 30 Mar 2026 16:07:53 GMT, Roland Westrelin <[email protected]> wrote:
>> This implements c2 and runtime support to pass a reference to an existing >> buffer, if there's one, as part of the scalarized calling convention. The >> buffer reference and the null marker are both always passed at this point. > > Roland Westrelin has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 26 commits: > > - more > - Merge branch 'lworld' into JDK-8372268 > - Merge branch 'lworld' into JDK-8372268 > - review > - Update src/hotspot/share/runtime/signature.hpp > > Co-authored-by: Tobias Hartmann <[email protected]> > - whitespaces > - test tweaks > - more > - aarch64 > - more > - ... and 16 more: > https://git.openjdk.org/valhalla/compare/7ed0bd92...8f90a9f6 Looks good to me otherwise. Thanks a lot for working on this! 🙂 src/hotspot/share/opto/compile.cpp line 2003: > 2001: } else if (u->is_CallJava()) { > 2002: CallJavaNode* call = u->as_CallJava(); > 2003: if (call->method() != nullptr && > call->method()->get_Method()->mismatch()) { Do we need a `call->method() != nullptr` check in lines 2009 and 2040 as well? src/hotspot/share/opto/compile.cpp line 2009: > 2007: for (uint k = TypeFunc::Parms; k < nargs; k++) { > 2008: Node* in = call->in(k); > 2009: if (in == n &&!call->method()->is_scalarized_buffer_arg(k - > TypeFunc::Parms)) { Suggestion: if (in == n && !call->method()->is_scalarized_buffer_arg(k - TypeFunc::Parms)) { ------------- Marked as reviewed by thartmann (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2062#pullrequestreview-4036031810 PR Review Comment: https://git.openjdk.org/valhalla/pull/2062#discussion_r3014706499 PR Review Comment: https://git.openjdk.org/valhalla/pull/2062#discussion_r3014694173
