On Tue, 31 Mar 2026 15:06:09 GMT, Tobias Hartmann <[email protected]> wrote:
>> Roland Westrelin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more
>
> src/hotspot/share/opto/compile.cpp line 2040:
>
>> 2038: Node* in = call->in(k);
>> 2039: if (wq.member(in)) {
>> 2040: assert(call->method()->is_scalarized_buffer_arg(k -
>> TypeFunc::Parms), "only buffer argument removed here");
>
> Do we need a null check here as well?
`call` was enqueued in the `calls` list if it can't be reached through one of
it's arguments or `call->method()` is non null and the argument is scalarized.
So we can't get here with a null `call->method()`. Or am I missing something?
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2062#discussion_r3016562126
