On Thu, 7 May 2026 08:32:25 GMT, Axel Boldt-Christmas <[email protected]> 
wrote:

>> VM_PrintClassLayout uses the wrong VMOp_Type.
>> 
>> Probably a copy paste error. Uses `VMOp_PrintClassHierarchy` instead of 
>> `VMOp_ClassPrintLayout`.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Axel Boldt-Christmas has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix the VMOp name

I think the reason it was called `ClassPrintLayout` is because it is used by 
`VM.class_print_layout` d/jcmd. However there is some discrepancy here in our 
internal symbol names. But as the VMOp_type name will be seen externally it 
should probably be consistent with the cmd.

I'll look at renaming `VM_PrintClassLayout`, `PrintClassLayout` and 
`PrintClassLayoutDCmd` to be consistent with `VM.class_print_layout`.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2401#issuecomment-4404716735

Reply via email to