On Mon, 11 May 2026 17:36:20 GMT, Chris Plummer <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: minor spec tweak > > src/hotspot/share/prims/jvmti.xml line 5893: > >> 5891: When preview features are enabled, the frame's method is >> a value class >> 5892: constructor and the requested local is a >> "<code>this</code>" value object, >> 5893: the value_ptr is set to a snapshot of the >> "<code>this</code>" object. > > I'm not so sure about the change to use "a 'this' value object" instead of > "the 'this' value object". Also, separating out the "value" part might help > here: > > > When preview features are enabled, if the frame's method is a value class > constructor, and the requested local is the “this” object, and “this” is a > value object, > then value_ptr is set to a snapshot of the "<code>this</code>" object. > > > and you might want to add the following clarifying statement at the end. I > think Dean suggested something along these lines: > > `… that represents the value object’s state at the point the snapshot is > taken.` Also, I'm not sure why we need to separately state "the frame's method is a value class constructor" and "the requested local is ... a value object" instead of just saying "the requested local is a value object under constructor": When preview features are enabled, if the requested local is the “this” object, and “this” is a value object under construction, then value_ptr is set to a snapshot of the "<code>this</code>" object. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2412#discussion_r3220971481
