On Thu, 4 Jun 2026 15:36:42 GMT, Viktor Klang <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 10 commits: >> >> - Add factory method combo case >> - Years >> - Stage review remarks >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> fix/ser-diff >> - Message updated >> - Add case for strict field class >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> fix/ser-diff >> - Block all serializable value classes >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> fix/ser-diff >> - Minimize serialization diff with mainline > > src/java.base/share/classes/jdk/internal/value/DeserializeFactory.java line > 42: > >> 40: @Retention(RetentionPolicy.RUNTIME) >> 41: @Target(value={CONSTRUCTOR, METHOD}) >> 42: public @interface DeserializeFactory { > > "Factory" tends to mean "static method", so if we need something which is > applicable for both constructors and factory methods, I think we need to have > a name change. "Deserializer"? Good idea, I love simple names! ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2326#discussion_r3357436176
