> There are few places which uses the fully qualified name for the > `AsValueClass` annotation. As a result the plugging does not modify these > classes when compiling, so they are still identity classes. > > I propose improving the robustness of this plugin. We need to do this during > parsing so we cannot actually check 100% that it will resolve to the correct > annotation. However we can do a best effort, which handles same package, > fully qualified, imported and rejects other annotations with the same class > name. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Check other class before package - Merge remote-tracking branch 'upstream_valhalla/lworld' into lworld-improve-ValueClassPlugin - Merge remote-tracking branch 'upstream_valhalla/lworld' into lworld-improve-ValueClassPlugin - Merge remote-tracking branch 'upstream_valhalla/lworld' into lworld-improve-ValueClassPlugin - Make ValueClassPlugin more robust ------------- Changes: - all: https://git.openjdk.org/valhalla/pull/2405/files - new: https://git.openjdk.org/valhalla/pull/2405/files/e0f36bb3..029a1b0f Webrevs: - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2405&range=03 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2405&range=02-03 Stats: 45039 lines in 1098 files changed: 26928 ins; 10317 del; 7794 mod Patch: https://git.openjdk.org/valhalla/pull/2405.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2405/head:pull/2405 PR: https://git.openjdk.org/valhalla/pull/2405
