On Tue, 9 Jun 2026 15:41:07 GMT, Axel Boldt-Christmas <[email protected]> wrote:
>> There are few places which uses the fully qualified name for the >> `AsValueClass` annotation. As a result the plugging does not modify these >> classes when compiling, so they are still identity classes. >> >> I propose improving the robustness of this plugin. We need to do this during >> parsing so we cannot actually check 100% that it will resolve to the correct >> annotation. However we can do a best effort, which handles same package, >> fully qualified, imported and rejects other annotations with the same class >> name. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Axel Boldt-Christmas has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Check other class before package > - Merge remote-tracking branch 'upstream_valhalla/lworld' into > lworld-improve-ValueClassPlugin > - Merge remote-tracking branch 'upstream_valhalla/lworld' into > lworld-improve-ValueClassPlugin > - Merge remote-tracking branch 'upstream_valhalla/lworld' into > lworld-improve-ValueClassPlugin > - Make ValueClassPlugin more robust This should obviously be done at semantic analysis-time (well, post-semantic analysis-time). I don't get why it has to be done at parse time, but OK, if you say so then I believe you. Besides, this is an improvement. ------------- Marked as reviewed by jsjolen (no project role). PR Review: https://git.openjdk.org/valhalla/pull/2405#pullrequestreview-4495607079
