> The specification of JVMTI GetClassModifiers needs some TLC. The spec was > carried over from the equivalent function in JVMDI but doesn't really specify > that it works like Class::getModifiers and returns Java language modifiers > and not necessarily the access flags from the class file. The change in > behavior to only set ACC_IDENTITY when the class is an identity class or > array makes it a good time to re-write the spec to align with existing and > future behavior. > > A new test is added to test this function with value classes. The tests are > added to the "newer" serviceability/jvmti tree. There are some older tests > for GetClassModifiers in vmTestbase/nsk suite so there is a bit of an overlap. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Change libGetClassModifiers to cpp - Merge branch 'lworld' into GetClassModifiers - Tweak wording - Initial commit ------------- Changes: - all: https://git.openjdk.org/valhalla/pull/2526/files - new: https://git.openjdk.org/valhalla/pull/2526/files/412b624e..0f1f85b9 Webrevs: - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2526&range=01 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2526&range=00-01 Stats: 42768 lines in 920 files changed: 26118 ins; 9391 del; 7259 mod Patch: https://git.openjdk.org/valhalla/pull/2526.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2526/head:pull/2526 PR: https://git.openjdk.org/valhalla/pull/2526
