On Wed, 10 Jun 2026 18:50:11 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Change libGetClassModifiers to cpp >> - Merge branch 'lworld' into GetClassModifiers >> - Tweak wording >> - Initial commit > > test/hotspot/jtreg/serviceability/jvmti/GetClassModifiers/libGetClassModifiers.cpp > line 51: > >> (failed to retrieve contents of file, check the PR for context) > A couple of nits: > - indent is better to be 2 > - converting to .cpp would be good Okay, moved it to .cpp. It was a bit of a coin toss initially as the tests in serviceability/jvmti have both .c and .cpp. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2526#discussion_r3394480922
