On Fri, 12 Jun 2026 16:33:36 GMT, Daniel D. Daugherty <[email protected]> wrote:
> I've taken a pass at resolving most of @erikj79's build related comments in > the Valhalla PR: > > [JDK-8317279](https://bugs.openjdk.org/browse/JDK-8317279) Standard library > implementation of value classes and objects > https://github.com/openjdk/jdk/pull/31123 > > A couple of the comments will be handled by separate issues: > - [JDK-8386451](https://bugs.openjdk.org/browse/JDK-8386451) [lworld] things > to delete from lworld just before integrating JEP-401 > - [JDK-8386458](https://bugs.openjdk.org/browse/JDK-8386458) [lworld] add > support for allowing value classes to declare native methods > > In this PR, I have reverted two of @MrSimms' heap sizes of 3200 to the > main-line's 2048. > I am testing this change with a Mach5 Tier[1-8]. Mach5 Tier[123458] have > completed > and there are no related test or task failures. Mach5 Tier[67] are still > executing and > are currently waiting for Mach5 resources. > > Update: I have added links to the comments in JDK-8317279 that discuss my > analysis > of the original code, where it came from and my proposed fix; gory details as > it were. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Ping @erikj79 and @MrSimms - Please review when you get the chance. Thanks! make/CompileJavaModules.gmk line 148: > 146: # correct output path location. We cannot compile directly into the > desired > 147: # directory because it's the compiler which creates the original > 148: # '<module>/<classpath>/...' hierarchy. See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884574&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884574 for the gory details. Several of @erikj79's comments were resolved by another fix. make/RunTestsPrebuiltSpec.gmk line 69: > 67: # Use hard-coded values for java flags (one size, fits all!) > 68: JAVA_FLAGS := -Duser.language=en -Duser.country=US > 69: JAVA_FLAGS_BIG := -Xms64M -Xmx2048M See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884164&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884164 for gory details. make/autoconf/boot-jdk.m4 line 447: > 445: JVM_HEAP_LIMIT_32="768" > 446: # Running a 64 bit JVM allows for and requires a bigger heap > 447: JVM_HEAP_LIMIT_64="2048" See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884164&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884164 for gory details. make/hotspot/lib/JvmFeatures.gmk line 58: > 56: macroAssembler_common.cpp > 57: JVM_CFLAGS_FEATURES += -DZERO \ > 58: -DZERO_LIBARCH='"$(OPENJDK_TARGET_CPU_LEGACY_LIB)"' $(LIBFFI_CFLAGS) See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884182&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884182 for the gory details. make/modules/java.base/gensrc/GensrcValueClasses.gmk line 29: > 27: # Generate the value class replacements for selected java.base source > files > 28: > 29: JAVA_BASE_VALUE_CLASS_REPLACEMENTS := \ See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884197&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884197 for the gory details. make/modules/java.base/gensrc/GensrcVarHandles.gmk line 49: > 47: VARHANDLE_$1_Type := \ > 48: $$(strip $$(subst NonAtomicReference, Reference, \ > 49: $$(subst NonAtomicFlatValue, FlatValue, > $$(VARHANDLE_$1_InputType)))) See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884223&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884223 for the gory details. make/test/BuildJtregValueClassPlugin.gmk line 34: > 32: # rewrites @AsValueClass classes to value classes at parse time) > together > 33: # with @AsValueClass and the META-INF service descriptor, compiled WITH > 34: # --enable-preview and the required internal-API exports. See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884232&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884232 for the gory details. make/test/BuildJtregValueClassPlugin.gmk line 88: > 86: > ################################################################################ > 87: > 88: include MakeFileEnd.gmk This puzzled me for a minute, then I remembered that the original file was missing an <EOL> at the end. make/test/BuildTestLib.gmk line 66: > 64: HEADERS := $(TEST_LIB_SUPPORT)/test-lib_headers, \ > 65: JAR := $(TEST_LIB_SUPPORT)/test-lib.jar, \ > 66: DISABLED_WARNINGS := preview, \ See https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884501&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884501 for the gory details. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2541#issuecomment-4693225861 PR Review Comment: https://git.openjdk.org/valhalla/pull/2541#discussion_r3404856370 PR Review Comment: https://git.openjdk.org/valhalla/pull/2541#discussion_r3404824315 PR Review Comment: https://git.openjdk.org/valhalla/pull/2541#discussion_r3404822841 PR Review Comment: https://git.openjdk.org/valhalla/pull/2541#discussion_r3404829383 PR Review Comment: https://git.openjdk.org/valhalla/pull/2541#discussion_r3404833266 PR Review Comment: https://git.openjdk.org/valhalla/pull/2541#discussion_r3404838103 PR Review Comment: https://git.openjdk.org/valhalla/pull/2541#discussion_r3404841191 PR Review Comment: https://git.openjdk.org/valhalla/pull/2541#discussion_r3404844913 PR Review Comment: https://git.openjdk.org/valhalla/pull/2541#discussion_r3404848281
