On Mon, 15 Jun 2026 08:37:49 GMT, Erik Joelsson <[email protected]> wrote:
>> I've taken a pass at resolving most of @erikj79's build related comments in >> the Valhalla PR: >> >> [JDK-8317279](https://bugs.openjdk.org/browse/JDK-8317279) Standard library >> implementation of value classes and objects >> https://github.com/openjdk/jdk/pull/31123 >> >> A couple of the comments will be handled by separate issues: >> - [JDK-8386451](https://bugs.openjdk.org/browse/JDK-8386451) [lworld] things >> to delete from lworld just before integrating JEP-401 >> - [JDK-8386458](https://bugs.openjdk.org/browse/JDK-8386458) [lworld] add >> support for allowing value classes to declare native methods >> >> In this PR, I have reverted two of @MrSimms' heap sizes of 3200 to the >> main-line's 2048. >> I am testing this change with a Mach5 Tier[1-8]. Mach5 Tier[123458] have >> completed >> and there are no related test or task failures. Mach5 Tier[67] are still >> executing and >> are currently waiting for Mach5 resources. >> >> Update: I have added links to the comments in JDK-8317279 that discuss my >> analysis >> of the original code, where it came from and my proposed fix; gory details >> as it were. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Marked as reviewed by erikj (no project role). @erikj79 - Thanks for the review! I'm double checking the last of my Mach5 testing right now ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2541#issuecomment-4713109200
