On Tue, 16 Jun 2026 15:46:20 GMT, Chen Liang <[email protected]> wrote:
>> Introduce a `PathResolution` to `ExplodedImage` to remove a lot of ad-hoc >> treatments of preview path discovery. Also some general comments and test >> additions. >> >> One interesting thing is the mainline jimage is not mapping >> `META-INF/preview/file` to `file` when preview is enabled; it does map >> `META-INF/preview/dir/file` to `dir/file`. Don't know if this is intended; >> exploded image performs the first mapping, which differs from jimage. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Review remarks > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > cleanup/lw-jrtfs > - Cleanup ExplodedImage and enhance SystemImageTest > One interesting thing is the mainline jimage is not mapping > META-INF/preview/file to file when preview is enabled; it does map > META-INF/preview/dir/file to dir/file. Don't know if this is intended; > exploded image performs the first mapping, which differs from jimage. There shouldn't be any cases right now that lead to resources going into the "top-level" META-INF/preview directory but I do see this would need attention, maybe with jlink too. We can create an issue in JBS to track this and maybe Sherman or Dusan can look at it. So to your question, the behavior with the exploded image looks right. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2545#issuecomment-4728873489
