On Wed, 17 Jun 2026 16:14:38 GMT, Chen Liang <[email protected]> wrote:

>> Introduce a `PathResolution` to `ExplodedImage` to remove a lot of ad-hoc 
>> treatments of preview path discovery. Also some general comments and test 
>> additions.
>> 
>> One interesting thing is the mainline jimage is not mapping 
>> `META-INF/preview/file` to `file` when preview is enabled; it does map 
>> `META-INF/preview/dir/file` to `dir/file`. Don't know if this is intended; 
>> exploded image performs the first mapping, which differs from jimage.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Chen Liang has updated the pull request with a new target base due to a merge 
> or a rebase. The incremental webrev excludes the unrelated changes brought in 
> by the merge/rebase. The pull request contains five additional commits since 
> the last revision:
> 
>  - Review comments
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into 
> cleanup/lw-jrtfs
>  - Review remarks
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into 
> cleanup/lw-jrtfs
>  - Cleanup ExplodedImage and enhance SystemImageTest

I have teared down `ResolvedPaths` per your suggestion. Indeed, in the end, the 
detection of resource, directory, and link node types becomes more 
straightforward.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2545#issuecomment-4737735018

Reply via email to