On Fri, 19 Jun 2026 13:04:43 GMT, Quan Anh Mai <[email protected]> wrote:
>> Christian Hagedorn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Quan-Anh > > src/hotspot/share/opto/library_call.cpp line 5203: > >> 5201: const TypeAryPtr* orig_t = _gvn.type(original)->isa_aryptr(); >> 5202: const TypeKlassPtr* tklass = _gvn.type(klass_node)->is_klassptr(); >> 5203: const bool is_src_abstract_flat_value_array = orig_t != nullptr && >> !orig_t->elem()->is_inlinetypeptr() && orig_t->is_flat(); > > Should we check for `!orig_t->is_not_flat()` instead? That's a good idea to cover all the cases where it could be flat. Updated this and the check for `tklass` as well accordingly. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2569#discussion_r3442694571
