On Fri, 19 Jun 2026 14:41:49 GMT, Quan Anh Mai <[email protected]> wrote:
>> Christian Hagedorn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix tklass > > src/hotspot/share/opto/library_call.cpp line 5215: > >> 5213: (orig_t == nullptr || (!orig_t->is_not_flat() >> && (!orig_t->is_flat() || orig_t->elem()->inline_klass()->contains_oops()))) >> && >> 5214: // Can dest array be flat and contain oops? >> 5215: can_dest_be_value_class_array && >> (!tklass->is_flat() || >> tklass->is_aryklassptr()->elem()->is_instklassptr()->instance_klass()->as_inline_klass()->contains_oops()))); > > This should also check for `tklass->is_not_flat()` instead. I agree. I also took another look at the code again and refactored it a bit to make `exclude_flat` easier to understand. Let me know, what you think. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2569#discussion_r3445695711
