On Fri, 26 Jun 2026 09:16:01 GMT, Tobias Hartmann <[email protected]> wrote:
>> Many of the new Valhalla compiler tests use the [IR >> Framework](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/lib/ir_framework/README.md) >> and should be run in `@run driver` mode because the framework will spawn a >> new test VM and we want to avoid that the framework itself is affected by VM >> flags. Unfortunately, this does not work with tests requiring >> `--enable-preview` and we therefore need to run these tests in `@run main` >> mode in Valhalla. `-Xcomp` and other expensive flags slow down execution >> significantly, wasting machine hours and causing timeouts. >> >> Jtreg 8.3 now finally supports driver mode with `--enable-preview` >> ([CODETOOLS-7904153](https://bugs.openjdk.org/browse/CODETOOLS-7904153)), so >> we can adjust the tests accordingly. >> >> With these changes, run time of `TestLWorld#id0` with `-Xcomp`, for example, >> improves by about **22.5%**. >> >> I'll hold off with integration until the new jtreg version becomes the >> default with [JDK-8386844](https://bugs.openjdk.org/browse/JDK-8386844). >> >> Thanks, >> Tobias >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Tobias Hartmann has updated the pull request incrementally with one > additional commit since the last revision: > > Fix Thanks for the review Christian! ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2585#issuecomment-4808285542
