> Many of the new Valhalla compiler tests use the [IR > Framework](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/lib/ir_framework/README.md) > and should be run in `@run driver` mode because the framework will spawn a > new test VM and we want to avoid that the framework itself is affected by VM > flags. Unfortunately, this does not work with tests requiring > `--enable-preview` and we therefore need to run these tests in `@run main` > mode in Valhalla. `-Xcomp` and other expensive flags slow down execution > significantly, wasting machine hours and causing timeouts. > > Jtreg 8.3 now finally supports driver mode with `--enable-preview` > ([CODETOOLS-7904153](https://bugs.openjdk.org/browse/CODETOOLS-7904153)), so > we can adjust the tests accordingly. > > With these changes, run time of `TestLWorld#id0` with `-Xcomp`, for example, > improves by about **22.5%**. > > I'll hold off with integration until the new jtreg version becomes the > default with [JDK-8386844](https://bugs.openjdk.org/browse/JDK-8386844). > > Thanks, > Tobias > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Tobias Hartmann has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'lworld' into JDK-8387256 - Update test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestIntrinsics.java Co-authored-by: Christian Hagedorn <[email protected]> - One more test - Fix - JDK-8387256 ------------- Changes: - all: https://git.openjdk.org/valhalla/pull/2585/files - new: https://git.openjdk.org/valhalla/pull/2585/files/659505ba..f025ef8a Webrevs: - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2585&range=04 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2585&range=03-04 Stats: 7995 lines in 266 files changed: 6112 ins; 1034 del; 849 mod Patch: https://git.openjdk.org/valhalla/pull/2585.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2585/head:pull/2585 PR: https://git.openjdk.org/valhalla/pull/2585
