On Thu, 9 Jul 2026 10:08:59 GMT, Viktor Klang <[email protected]> wrote:

>> doc/value-class-preview.md line 8:
>> 
>>> 6: to value classes. This means that when preview features are enabled, a 
>>> different
>>> 7: classpath is available to Java programs. To accomplish this, the JDK has 
>>> a
>>> 8: custom build and deployment process to allow access to different 
>>> classpaths.
>> 
>> I think this intro should explicit words to the effect of "there are 
>> separate class files for migrated value classes with preview enabled and 
>> with preview enabled. First new source files are generated from the original 
>> files to be migrated and then these new source files are compiled into 
>> separate class files are put into a distinct class path, etc."
>> 
>> (The salient point here for core libs maintainers include there is a new 
>> source-based transform and, as explained later in the note, understanding 
>> the limited functionality of the transform. Other technically possible ways 
>> to do this transform would include class file re-writing, possibly at 
>> startup, etc.)
>
> I think Joe makes a good point here

Added a somewhat better overview for this.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2633#discussion_r3555023657

Reply via email to