On Thu, 9 Jul 2026 05:20:35 GMT, Joe Darcy <[email protected]> wrote:
>> This is some extremely basic overview about value class migrations. >> >> 1. Build: I intentionally skipped the streamlined build system installed by >> David Beaumont. Instead, I stressed the custom handling used by Value >> Objects JEP. (The "Preview Classes in Interim `javac`" section might go to >> general documentation later.) >> >> 2. Testing: I started from the motivations/goals and describe how those >> goals are accomplished. >> 3. Wrapper class caches: Some simple overview. >> >> There are definitely more topics to cover; feel free to raise. >> >> Paging @jddarcy and @viktorklang-ora for proofreading. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > And once the text of the note if finalized, links to it in `//` comments > should be added to the wrapper classes and the `java.time` classes. After commentsI had some minor comments, and after addressing those I think this is ready from my point-of-view. I'll let @jddarcy decide if anything more is necessary. > doc/value-class-preview.md line 8: > >> 6: to value classes. This means that when preview features are enabled, a >> different >> 7: classpath is available to Java programs. To accomplish this, the JDK has a >> 8: custom build and deployment process to allow access to different >> classpaths. > > I think this intro should explicit words to the effect of "there are separate > class files for migrated value classes with preview enabled and with preview > enabled. First new source files are generated from the original files to be > migrated and then these new source files are compiled into separate class > files are put into a distinct class path, etc." > > (The salient point here for core libs maintainers include there is a new > source-based transform and, as explained later in the note, understanding the > limited functionality of the transform. Other technically possible ways to do > this transform would include class file re-writing, possibly at startup, etc.) I think Joe makes a good point here ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2633#issuecomment-4936037692 PR Review Comment: https://git.openjdk.org/valhalla/pull/2633#discussion_r3550724134
