On Thu, 16 Jul 2026 19:26:45 GMT, Dan Smith <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Restructuring and rewording >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> doc/lw-vb-ctor-ice >> - Minor ValueBased and InvalidClassException comments > > src/java.base/share/classes/java/lang/doc-files/ValueBased.html line 76: > >> 74: <p>When preview features are enabled, some value-based classes become >> value classes. >> 75: Instances of these classes become value objects, which have >> different identity-related >> 76: behaviors compared to identity objects, as described in {@link >> Object}:</p> > > I don't want to treat Object as the Source of Truth here, maybe just delete > "as desribed in Object:" and say "including:". Should the specification of `java.lang.Object` be the source of truth for the semantics of `Object`? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2631#discussion_r3598547579
