Hi Theo and all,

> Varnish 2.0.3 appears to fail b17 and c22 tests in the suite for me.

They do because a eventually a null pointer is passed to strlen.

Here's a fix:

--- varnish-2.0.3_with_sticky_url_director/bin/varnishd/cache_vrt.c     Thu Feb 
12 
12:15:25 2009
+++ varnish-2.0.3_no_sticky_url_director/bin/varnishd/cache_vrt.c       Sat Feb 
28 
20:32:16 2009
@@ -62,7 +62,7 @@
  {

        CHECK_OBJ_NOTNULL(sp, SESS_MAGIC);
-       WSL(sp->wrk, SLT_Debug, 0, "VCL_error(%u, %s)", code, reason);
+       WSL(sp->wrk, SLT_Debug, 0, "VCL_error(%u, %s)", code, reason ? reason : 
"NULL");
        sp->err_code = code ? code : 503;
        sp->err_reason = reason ? reason : http_StatusMessage(sp->err_code);
  }

I'll open a bug for that one.

By the way, does anyone have an idea yet how to make timeouts work on Solaris 
(tests b20-b25 failing)?

Thanks a lot,

Nils
_______________________________________________
varnish-dev mailing list
varnish-dev@projects.linpro.no
http://projects.linpro.no/mailman/listinfo/varnish-dev

Reply via email to