Hi Federico, On 22/07/14 02:26, Federico Schwindt wrote: > I've changed your diff to avoid splitting rollback. I don't think we should > make > that distinction.
I had considered this approach also (see yesterday's irc log) but ditched it because I thought checking context in VCC would be better than checking at runtime - and VCC would have required more attention to become "context sensitive". Other than that I am fine with your change in principle - but I have not tested it. NilsTitle: Conversation with #varnish-hacking at Mon 21 Jul 2014 11:55:00 CEST on [email protected] (irc)
Conversation with #varnish-hacking at Mon 21 Jul 2014 11:55:00 CEST on [email protected] (irc)
(11:55:00) The topic for #varnish-hacking is: Varnish 4.0.1 released! https://www.varnish-cache.org/lists/pipermail/varnish-announce/2014-June/000697.html(11:55:00) Topic for #varnish-hacking set by [email protected] at 13:56:45 on 24/06/14
(12:07:29) maryam [maryam@2001:840:4904:1:3c22:5dcd:261f:f922] entered the room.
(12:07:31) maryam_ [maryam@2001:840:4904:1:3c22:5dcd:261f:f922] entered the room.
(12:13:48) slink: Should we have a way to preserve state between bereq retries?
(12:17:38) scoof: yes. #1512
(12:18:52) slink: scoof: thanks
(12:28:41) jw_irc.vs: slink: aren't you supposed to enjoy your vacation?
(12:28:50) jw_irc.vs: someone should ban you for a while
(12:31:42) Mithrandir / tfheen: slink: how's the island?
(12:31:56) slink: haha
(12:32:40) slink: Kristina thinks it was too hot outside to take a walk, so I thought I could look after a problem our martin has
(12:32:46) slink: Hidra is GREAT
(12:32:59) dberg [[email protected]] entered the room.
(12:33:37) scoof: slink: scn recommended vmod-var as a workaround to somebody else. I'm not sure how far it scales
(12:33:46) daghf: vmod var doesn'
(12:34:13) daghf: doesn't quite work on the backend side of vcl in v4 yet.
(12:34:47) slink: On #1512: I think we should either have two rollbacks (one for client, one for bereq) and have retry not copy from bereq0 again, or we should make rollback sensitive to the context (rollback req in client, rollback bereq in backend). Opinions?
(12:35:37) scoof: retry should definitely not rollback. I like the idea of rollback being context sensitive
(12:38:07) daghf: I think context sensitive makes sense
(12:38:21) daghf: that said, it looks like bereq.http and req.http are both available in vcl_pipe
(12:38:29) daghf: ..
(12:38:49) slink: is phk working today?
(12:38:53) scoof: no
(12:40:26) daghf: I guess doing a rollback for bereq wouldn't make much sense in vcl_pipe anyway
(12:43:03) dberg left the room (quit: Ping timeout: 301 seconds).
(12:43:32) dberg [[email protected]] entered the room.
(12:44:07) slink: daghf: seems to make sense to me as we can't restart from pipe
(12:44:37) daghf: Ah, right
(12:53:36) dberg left the room (quit: Ping timeout: 301 seconds).
(13:15:44) slink: hm, the idea of context sensitive actions does not fit too well into the existing vcc code
(13:16:23) slink: having rollback_req and rollback_backend should be easy
(13:16:37) slink: or what about req.rollback and bereq.rollback ?
(13:16:49) phk: slink, you should not be able to do rollback_req on the backend side, req is read-only there.
(13:17:31) slink: I think on current master it would roll back
(13:17:49) slink: so this probably is a chance to improve things
(13:19:23) slink: req.rollback and bereq.rollback do not fit in either because this is the variables notation. So I'd want to go for req_rollback and bereq_rollback ...?
(13:23:17) slink: phk: got an opinion on https://www.varnish-cache.org/patchwork/patch/171/ ?
(13:26:07) phk: slink, not today, about to give a talk at thecamp.dk
(13:27:25) slink: cool! the kamp at the camp :D
(13:31:41) dberg [[email protected]] entered the room.
(13:37:55) dberg left the room (quit: SSL Connection closed).
(13:58:32) hpeter [[email protected]] entered the room.
(14:38:39) slink: posted patches for #1512.
(14:38:56) slink: reviews welcome BY EMAIL, I am going back to HidraHolidayMode now :)
(14:40:32) Mithrandir / tfheen: slink: enjoy, and say hi to your family again
(14:40:38) Mithrandir / tfheen: it was great to see you all again
(14:41:56) slink: Mithrandir: Hello back from Kristina and yes, it was great meeting you in Oslo. And the food even passed my MSG test :D
(14:43:02) Mithrandir / tfheen: oh, you don't do msg?
(14:43:30) slink: Mono Sodium Glutamate that is
(14:45:32) Mithrandir / tfheen: yeah, I know what msg is
(14:45:42) slink: ah. yes, I get sick from it
(14:45:55) slink: allergenic reaction...
(14:46:57) slink: signing off for real now. Have a nice day everyone, we're leaving to enjoy the beauties of Norway \o/
(14:47:04) The account has disconnected and you are no longer in this chat. You will automatically rejoin the chat when the account reconnects.
_______________________________________________ varnish-dev mailing list [email protected] https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
