--------
In message <CAJV_h0bR-h=i0e-GKwZrd5fE9q-1AsF=_sJ=gFJQ=6cbif0...@mail.gmail.com>
, Federico Schwindt writes:

Two things, on trivial-ish and the other serious-ish.

The trivial thing is that I think we should put the actual
rollback in VRT_Rollback() (give it an VCL_HTTP argument) so that
std.rollback just wraps that.

The other thing is that I'm not even close to being convinced that
resetting the workspace is safe anymore, and I have no idea how I
can convince myself that it is, in a world full of VMODs.

We may have to give up on that, and only rollback the struct http.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
[email protected]         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

_______________________________________________
varnish-dev mailing list
[email protected]
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Reply via email to