Zitat von "Sunagawa Koji / 砂川 孝児" <[EMAIL PROTECTED]>:

> you can use clear passwd with my patch.
> Please Try this patch. It is for 5.3.9.
> http://www.ofug.net/~koj/vpopmail-ldap-apop/vpopmail-ldap-apop-20020917.tar.gz


good job !

But it wont apply against 5.3.12.

- In my CVS-Tree I thought about dynamically using LDAP-entries, because
  hardcoding a special row for a special entrie makes it worse to add more new 
  LDAP-entries, because you have a bunge of #ifdefs and you will have to 
  doublecheck the whole code where direct access to an LDAP-entry is made

As a result I think it is nice to just address an LDAP-Entrie via pointers.
qmailUID = 3;

which are dynamically setup.

So general access to it would be

#ifdef CLEAR_PW
lm[CLEAR_PW]->mod_values[0] = strdup(password);

next would be 

lm[QMAILDOMAIN]->mod_values[0] = strdup(password);

no matter if I "ifdefed" CLEAR_PW or not.
This make code much more easy and readable.

Hope you understand my point and tell me what do you think.

I will release a patch for vpopmail-5.3.12 that uses your way, but I am
of the opinion to have a clear interface to what is used or not is better than 
using static addresses.



Reply via email to