Tom Collins <[EMAIL PROTECTED]> wrote:
One question related to the vpalias.c fix. Why is mydir static? It's
always set to NULL before that function exits. Wouldn't making it not
static and initializing it to NULL make more sense?
mydir was static in vpopmail-5.4.16, so I didn't set that. Looking at it now, I'm not really sure why. From the same token, I'm not sure if it's worth changing. Possibly to ensure that mydir is closed on any second itteration in case it hits one of those returns?