Bugs item #3094631, was opened at 2010-10-25 07:32
Message generated for change (Settings changed) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=611248&aid=3094631&group_id=95403

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 7
Private: No
Submitted By: Daniele Lacamera (danielel)
Assigned to: Francesco Apollonio (lord_dex)
Summary: wirefilter: unsigned long long overflow on delay calculation

Initial Comment:
As wirefilter keeps time in nanoseconds, a uint64 overflow is likely to occur.
Francesco A. aka lord_...@sf, who was investigating on wirefilter lockup for 
his thesis work, discovered this bug and already has a fix.

He is currently preparing a patch for commit. Please add him to the project as 
developer


----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2010-11-08 21:20

Message:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: Luca Bigliardi (shammash)
Date: 2010-10-28 14:25

Message:
Hi Francesco,

Thanks for your patch, the changes look good. I've just a note on the
first hunk: theoretically you can still have some overflows on deltat
because it's not unsigned. 

Maybe you should do something like:

if when > now
  return (unsigned long long)when-now
else
  return 0

Thank you!

Luca


----------------------------------------------------------------------

Comment By: Francesco Apollonio (lord_dex)
Date: 2010-10-26 12:57

Message:
Hi,

I'm working on my graduation thesis using kvm e vde2 to create a virtual
testbed.
During my tests frequently wirefilter stopped working, it didn't dequeue
packets because time variables apparently returned back in the past for the
overflow.
I'm including my proposed patch (that is working properly on testbed). If
it looks good, I would commit it in the next days.

Francesco

----------------------------------------------------------------------

Comment By: Luca Bigliardi (shammash)
Date: 2010-10-25 20:53

Message:
Hi Daniele,

I've added Francesco as a developer, he should have svn access now.
I'm leaving the bug open, do be closed once the fix has been submitted.
Feel free to post the proposed patch here if you want to discuss it.

Luca


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=611248&aid=3094631&group_id=95403

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
vde-users mailing list
vde-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/vde-users

Reply via email to