On 02/23/13 at 04:28PM +0100, Christopher Reimer wrote: > Am 23.02.2013 15:40, schrieb Ville Skyttä: > > On 2013-02-23 14:43, Tobi wrote: > > > >> VDR's Makefile does not use CPPFLAGS (C-Pre-Processor flags) right > >> now. > >> Not a big deal and easy to work-around, but for the sake of providing > >> a > >> "standards-conform" Makefile I suggest adding CPPFLAGS as well. > > +1 to the general idea. > > To take it a bit further, I suppose at least DEFINES, CDEFINES, > > INCLUDES, CINCLUDES could be directly put to CPPFLAGS instead of being > > defined separately. > > > > +1 for Tobi's suggestion and +1 for yours. > > I didn't know that there's something else than CXXFLAGS, CFLAGS and > LDFLAGS. The Archlinux build system only provides these three. > > Tobi's patch is minimally invasive (Ready for 2.0), but I'm afraid that > your suggestion breaks something (better wait for 2.0+) >
+1. It should be fine as long as VDR does append to the CPPFLAGS and as long as the "user" does not override those by using e.g. "make CPPFLAGS="..."" instead of "CPPFLAGS="..." make ...". -- Regards, Christian Ruppert
pgpWqhoo5Fjm_.pgp
Description: PGP signature
_______________________________________________ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
