Hi, I've pushed a new version of my patch. There are still minor todos, but I took advice of Toni to rewrite the last version so that VDSM internally uses new GraphicsDevice(VmDevice) class to represent graphics.
Feel free to comment it. Thanks, Franta. ----- Original Message ----- From: "Frantisek Kobzik" <fkob...@redhat.com> To: vdsm-devel@lists.fedorahosted.org Sent: Friday, March 28, 2014 1:06:17 PM Subject: [vdsm] Modeling graphics framebuffer device in VDSM Dear VDSM devels, I've been working on refactoring graphics devices in engine and VDSM for some time now and I'd like know your opinion of that. The aim of this refactoring is to model graphics framebuffer (SPICE, VNC) as device in the engine and VDSM. This which is quite natural since libvirt treats graphics as a device and we have some kind of devices infrastructure in both projects. Another advantage (and actually the main reason for refactoring) is simplified support for multiple graphics framebuffers on a single vm. Currently, passing information about graphics from engine to VDSM is done via 'display' param in conf. In the other direction VDSM informs the engine about graphics parameters ('displayPort', 'displaySecurePort', 'displayIp' and 'displayNetwork') in conf as well. What I'd like to achieve is to encapsulate all this information in specParams of the new graphics device and use specParams as a place for transfering data about graphics device between engine and vdsm. What do you think? the draft patch is here: http://gerrit.ovirt.org/#/c/23555/ (it's currently marked with '-1' but it puts some light on what the solution looks like so feel free to take a look). Thanks, Franta. _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel