Lei Li has posted comments on this change. Change subject: Add passwd command to vdsm-tool ......................................................................
Patch Set 10: (1 inline comment) .................................................... File vdsm-tool/passwd.py Line 36: except IOError: I modify it based on your comment.. " I should have noticed this earlier, but you should `return` on errno.ENOENT." To deal with the missing of this file P_VDSM_LIBVIRT_PASSWD. Please see the comment in the former set, did I misunderstand? -- To view, visit http://gerrit.ovirt.org/4528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b5aee4c2f11a7680c675c171ff35a463a70402 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <li...@linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Lei Li <li...@linux.vnet.ibm.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: Wenyi Gao <we...@linux.vnet.ibm.com> Gerrit-Reviewer: Xu He Jie <x...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
