Lei Li has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File vdsm-tool/passwd.py
Line 41: raise IOError(e.errno, os.strerror(e.errno))
Okey..
Line 48: raise Exception("Set password failed: %s" % p.returncode)
raise err like this would hang up in this case. And since the input command was
already wrapped, the possible return error would be 'generic failure' , like
the user doesn't have the right accession. So I think it would not be more
useful to print the err.
--
To view, visit http://gerrit.ovirt.org/4528
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b5aee4c2f11a7680c675c171ff35a463a70402
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Lei Li <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
