Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File vdsm-tool/base.py
Line 40: logging.error(traceback.format_exc())
I think we moved away from traceback.format_exc to exc_info=True.
logging.error("Failed to execute '%s', argv, exc_info=True)
Line 53: cmd += ' ' + arg
How about:
cmd = ' '.join([cmd] + ['%s=%s' % i for i in kwargs.iteritems()] + args)
Line 71: def print_failure_msg(msg):
I feel this could be combined with print_success_msg into print_msg. I also
think you can replace the subprocess calls to echo with plain print.
--
To view, visit http://gerrit.ovirt.org/5264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1be737adce28e9ca532aa454e7f0a060947589e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
