Douglas Schilling Landgraf has posted comments on this change. Change subject: Add some base functions to vdsm-tool ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) Hi Wenyi, thanks for your patch. I do believe you are going to provide a new version based on the comments. -1 for while. Thanks! .................................................... File vdsm-tool/base.py Line 43: def call(*args, **kwargs): +1 Line 64: subprocess.call(['echo', '-n', msg]) +1 -- To view, visit http://gerrit.ovirt.org/5264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1be737adce28e9ca532aa454e7f0a060947589e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Wenyi Gao <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
