Bing Bu Cao has posted comments on this change. Change subject: VM.create: Make readonly optional for disk devices ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 1066: if hasattr(self, 'readonly') and utils.tobool(self.readonly): I have tried to fix this issue before. But after discussed with Mark,he said with ovirt-engine the readonly attribute will be set anyway. So...,it is unnecessary. -- To view, visit http://gerrit.ovirt.org/5298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83b43ef02b38091a8b3bfd1a9d0485e3b04323c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
