Mark Wu has posted comments on this change. Change subject: VM.create: Make readonly optional for disk devices ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 1066: if hasattr(self, 'readonly') and utils.tobool(self.readonly): Bing Bu, I am sorry for misleading you. I mean ovirt engine did not cause break, but when vdsm runs in a standalone mode, it's a problem. It makes sense to make 'readonly' optional -- To view, visit http://gerrit.ovirt.org/5298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83b43ef02b38091a8b3bfd1a9d0485e3b04323c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
