Ayal Baron has posted comments on this change. Change subject: BZ#834893: vms with shared disk will pause... ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 1058: if hasattr(self, 'shared') and utils.tobool(self.shared): all params are mandatory, it makes the API simpler. No need for hasattr, previous version was fine -- To view, visit http://gerrit.ovirt.org/6283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82714a3a4fd86184b8ed48ef33ce69d0640d96ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
