Igor Lvovsky has posted comments on this change. Change subject: BZ#840386: vms with shared disk will pause... ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) Look at my comment inside .................................................... File vdsm/libvirtvm.py Line 1058: if utils.tobool(self.shared): Eli, just don't forget that you MUST to send 'share' not only for disks, but for cdrom and floppy too. or you need to check hasattr for it. -- To view, visit http://gerrit.ovirt.org/6283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82714a3a4fd86184b8ed48ef33ce69d0640d96ed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
