Francesco Romani has posted comments on this change. Change subject: virt: Only filter guest agent data, only on XMLRPC ......................................................................
Patch Set 10: Code-Review-1 (1 comment) I don't like to pass filter=blah all around, but can't think of anything better. -1 because undoing of (admittedly tiny) optimization in API.py, please see inline comments. https://gerrit.ovirt.org/#/c/36949/10/vdsm/API.py File vdsm/API.py: Line 1316: """ Line 1317: Get statistics of all running VMs. Line 1318: """ Line 1319: hooks.before_get_all_vm_stats() Line 1320: vms = self.getVMList() please fix _cif.getAllVmStats() instead Line 1321: statsList = [] Line 1322: for s in vms['vmList']: Line 1323: response = VM(s['vmId'])._getStats(runHooks=False, Line 1324: filtered=filtered) -- To view, visit https://gerrit.ovirt.org/36949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ee2a8f1cc6784c619ce68da3cb9342b0d72cfc Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
