Douglas Schilling Landgraf has posted comments on this change. Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/vdsmd.init.in Line 161: for srv in $NEEDED_SERVICES Line 162: do Line 163: if ! /sbin/service $srv status > /dev/null 2>&1; # Verify that status is inactive Line 164: then Line 165: echo "Starting $srv..." Looks like a lost tab here. Line 166: /sbin/service $srv start Line 167: ret_val=$? Line 168: if [ $ret_val -ne 0 ] Line 169: then -- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
