Douglas Schilling Landgraf has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vdsmd.init.in
Line 160:
Line 161: for srv in $NEEDED_SERVICES
Line 162: do
Line 163: if ! /sbin/service $srv status > /dev/null 2>&1; # Verify
that status is inactive
Line 164: then
looks like an additional space
Line 165: echo "Starting $srv..."
Line 166: /sbin/service $srv start
Line 167: ret_val=$?
Line 168: if [ $ret_val -ne 0 ]
Line 179: test_lo() {
Line 180: if ! LC_ALL=C /sbin/ifconfig lo | /bin/grep -q UP;
Line 181: then
Line 182: log_failure_msg "VDSMD: lo interface is down, can't run !"
Line 183: echo "VDSMD: lo interface is down, can't run !" > /dev/kmsg
looks like an additional space
Line 184: return 1
Line 185: fi
Line 186: return 0
Line 187: }
--
To view, visit http://gerrit.ovirt.org/7340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
